fix(ignore): Added descriptions and support 1-3 phase variants of ZJSBL7-100Z #5856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
reviewed
Jun 7, 2023
src/lib/legacy.ts
Outdated
| @@ -4676,6 +4676,15 @@ const fromZigbee1 = { | |||
| } | |||
| if (dp === dataPoints.hochActivePower) { | |||
| result.power = (value[2] | value[1] << 8) / 10; | |||
| if (value.length > 3) { | |||
| result.power_1 = (value[5] | value[4] << 8) / 10; | |||
There was a problem hiding this comment.
can you rename these to e.g. power_l1? (add l)
…BL7-100Z Signed-off-by: Ondrej Pecta <opecta@gmail.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds descriptions for exposed values and exposes power consumption on the each phase besides the overall power consumption.
there are more variants of ZJSBL7-100Z (1,2,3 phase) and therefore it rather checks if there is data of the power consumption on the each phase.